mmc: tmio_mmc: silence compiler warnings

with "mmc: tmio: implement a bounce buffer for unaligned DMA"
gcc generates the following warnings:

drivers/mmc/host/tmio_mmc.c:654:6: warning: 'ret' may be used uninitialized in this function
drivers/mmc/host/tmio_mmc.c:730:6: warning: 'ret' may be used uninitialized in this function

This patch fixes these by setting ret to -EINVAL in the affected code paths.

Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
Signed-off-by: Chris Ball <cjb@laptop.org>

diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
index 595b7b3f160d3b5cbf905cacddff27d1e9acac46..f442c8205b0af4825449efd456933b33df17ad17 100644 (file)
--- a/drivers/mmc/host/tmio_mmc.c
+++ b/drivers/mmc/host/tmio_mmc.c
@@ -673,8 +673,10 @@ static void tmio_mmc_start_dma_rx(struct tmio_mmc_host *host)
        }
 
        if ((!aligned && (host->sg_len > 1 || sg->length > PAGE_CACHE_SIZE ||
-                         align >= MAX_ALIGN)) || !multiple)
+                         align >= MAX_ALIGN)) || !multiple) {
+               ret = -EINVAL;
                goto pio;
+       }
 
        /* The only sg element can be unaligned, use our bounce buffer then */
        if (!aligned) {
@@ -748,8 +750,10 @@ static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host)
        }
 
        if ((!aligned && (host->sg_len > 1 || sg->length > PAGE_CACHE_SIZE ||
-                         align >= MAX_ALIGN)) || !multiple)
+                         align >= MAX_ALIGN)) || !multiple) {
+               ret = -EINVAL;
                goto pio;
+       }
 
        /* The only sg element can be unaligned, use our bounce buffer then */
        if (!aligned) {