]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
PCI: designware: Fix configuration base address when using 'reg'
authorMinghuan Lian <Minghuan.Lian@freescale.com>
Tue, 23 Sep 2014 14:28:56 +0000 (22:28 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 24 Sep 2014 13:01:47 +0000 (07:01 -0600)
The code has calculated cfg0_base and cfg1_base when parsing 'reg' or
'ranges' property of PCI DTS node, so remove duplicate calculation.  When
using 'reg', resource cfg is not used, so this code computed an incorrect
configuration base.

Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Mohit KUMAR <mohit.kumar@st.com>
drivers/pci/host/pcie-designware.c

index 1c59e4e6b2f0ddc65f8f7e2a07962ebd4d46843a..b0dd2606edeeb1dcd9d377f0101081ce599b0419 100644 (file)
@@ -510,7 +510,6 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
        pp->mem_base = pp->mem.start;
 
        if (!pp->va_cfg0_base) {
-               pp->cfg0_base = pp->cfg.start;
                pp->va_cfg0_base = devm_ioremap(pp->dev, pp->cfg0_base,
                                                pp->cfg0_size);
                if (!pp->va_cfg0_base) {
@@ -520,7 +519,6 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
        }
 
        if (!pp->va_cfg1_base) {
-               pp->cfg1_base = pp->cfg.start + pp->cfg0_size;
                pp->va_cfg1_base = devm_ioremap(pp->dev, pp->cfg1_base,
                                                pp->cfg1_size);
                if (!pp->va_cfg1_base) {