]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
RDMA/ocrdma: Do not skip setting deferred_arm
authorDevesh Sharma <devesh.sharma@emulex.com>
Mon, 9 Jun 2014 05:22:38 +0000 (10:52 +0530)
committerRoland Dreier <roland@purestorage.com>
Fri, 19 Sep 2014 16:53:35 +0000 (09:53 -0700)
When ib_request_notify_cq() is called for the first time, ocrdma tries
to skip setting deffered_arm flag. This may lead CQ to an un-armed
state thus never generating a CQ event and leaving consumer hung.

This patch removes the part of code that skips setting deferred_arm.

Signed-off-by: Devesh Sharma <devesh.sharma@emulex.com>
Signed-off-by: Selvin Xavier <selvin.xavier@emulex.com>
Signed-off-by: Mitesh Ahuja <mitesh.ahuja@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

index 4527311171c5da95b4f12d9f35406e40398b3e88..8f5f2577f28855eae258b278484a2bdda2eaf396 100644 (file)
@@ -2846,11 +2846,9 @@ int ocrdma_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags cq_flags)
        if (cq->first_arm) {
                ocrdma_ring_cq_db(dev, cq_id, arm_needed, sol_needed, 0);
                cq->first_arm = false;
-               goto skip_defer;
        }
-       cq->deferred_arm = true;
 
-skip_defer:
+       cq->deferred_arm = true;
        cq->deferred_sol = sol_needed;
        spin_unlock_irqrestore(&cq->cq_lock, flags);