]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
bfa: Fix undefined bit shift on big-endian architectures with 32-bit DMA address
authorBen Hutchings <ben@decadent.org.uk>
Sun, 8 Jun 2014 22:33:25 +0000 (23:33 +0100)
committerChristoph Hellwig <hch@lst.de>
Fri, 25 Jul 2014 21:16:54 +0000 (17:16 -0400)
commit03a6c3ff3282ee9fa893089304d951e0be93a144
tree26c7b0268508c66ee5715bf935fcaf803aeeb8a4
parent7626d9f36cdeab32bd12ea783aa8ee9fea0a41a2
bfa: Fix undefined bit shift on big-endian architectures with 32-bit DMA address

bfa_swap_words() shifts its argument (assumed to be 64-bit) by 32 bits
each way.  In two places the argument type is dma_addr_t, which may be
32-bit, in which case the effect of the bit shift is undefined:

drivers/scsi/bfa/bfa_fcpim.c: In function 'bfa_ioim_send_ioreq':
drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: left shift count >= width of type [enabled by default]
    addr = bfa_sgaddr_le(sg_dma_address(sg));
    ^
drivers/scsi/bfa/bfa_fcpim.c:2497:4: warning: right shift count >= width of type [enabled by default]
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: left shift count >= width of type [enabled by default]
    addr = bfa_sgaddr_le(sg_dma_address(sg));
    ^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of type [enabled by default]

Avoid this by adding casts to u64 in bfa_swap_words().

Compile-tested only.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: stable@vger.kernel.org
Fixes: f16a17507b09 ('[SCSI] bfa: remove all OS wrappers')
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/bfa/bfa_ioc.h