]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
s390: use device_remove_file_self() instead of device_schedule_callback()
authorTejun Heo <tj@kernel.org>
Mon, 3 Feb 2014 19:03:04 +0000 (14:03 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Feb 2014 23:42:41 +0000 (15:42 -0800)
commit0b60f9ead5d4816e7e3d6e28f4a0d22d4a1b2513
tree2c46f7db6815641b51553b3c4bfa5a76e0ccd06d
parentac0ece9174aca9aa895ce0accc54f1f8ff12d117
s390: use device_remove_file_self() instead of device_schedule_callback()

driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal.  Use it
instead of device_schedule_callback().

* Conversions in arch/s390/pci/pci_sysfs.c and
  drivers/s390/block/dcssblk.c are straightforward.

* drivers/s390/cio/ccwgroup.c is a bit more tricky because
  ccwgroup_notifier() was (ab)using device_schedule_callback() to
  purely obtain a process context to kick off ungroup operation which
  may block from a notifier callback.

  Rename ccwgroup_ungroup_callback() to ccwgroup_ungroup() and make it
  take ccwgroup_device * instead.  The new function is now called
  directly from ccwgroup_ungroup_store().

  ccwgroup_notifier() chain is updated to explicitly bounce through
  ccwgroup_device->ungroup_work.  This also removes possible failure
  from memory pressure.

Only compile-tested.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/s390/include/asm/ccwgroup.h
arch/s390/pci/pci_sysfs.c
drivers/s390/block/dcssblk.c
drivers/s390/cio/ccwgroup.c