]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
efi: Use the generic efi.memmap instead of 'memmap'
authorMatt Fleming <matt@codeblueprint.co.uk>
Sat, 3 Oct 2015 22:26:07 +0000 (23:26 +0100)
committerIngo Molnar <mingo@kernel.org>
Sun, 11 Oct 2015 09:04:18 +0000 (11:04 +0200)
commit0ce423b6492a02be11662bfaa837dd16945aad3e
tree2f19fb9a508201dc3744b064e51f65dfa6475282
parent8ece249a811e93d3f60e3f1ebdc86c7e7a95bdbf
efi: Use the generic efi.memmap instead of 'memmap'

Guenter reports that commit:

  7bf793115dd9 ("efi, x86: Rearrange efi_mem_attributes()")

breaks the IA64 compilation with the following error:

  drivers/built-in.o: In function `efi_mem_attributes': (.text+0xde962): undefined reference to `memmap'

Instead of using the (rather poorly named) global variable
'memmap' which doesn't exist on IA64, use efi.memmap which
points to the 'memmap' object on x86 and arm64 and which is NULL
for IA64.

The fact that efi.memmap is NULL for IA64 is OK because IA64
provides its own implementation of efi_mem_attributes().

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jonathan Zhang <zjzhang@codeaurora.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/20151003222607.GA2682@codeblueprint.co.uk
Signed-off-by: Ingo Molnar <mingo@kernel.org>
drivers/firmware/efi/efi.c