]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
remoteproc/davinci: simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 14 Aug 2013 09:11:28 +0000 (11:11 +0200)
committerOhad Ben-Cohen <ohad@wizery.com>
Mon, 24 Feb 2014 09:10:24 +0000 (11:10 +0200)
commit0ddc5ec1c1f4d776a8e702b3bcc25daa015b8de6
tree5a15154a5a685e96b277d6e99f61ae240b69124b
parent5d658bfdb4ca797104f3ad9a88dae86bee0ac77a
remoteproc/davinci: simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[simplify patch title]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
drivers/remoteproc/da8xx_remoteproc.c