]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pcm: another weird API abuse
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 4 Apr 2015 04:19:32 +0000 (00:19 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Apr 2015 02:29:43 +0000 (22:29 -0400)
commit1c65d98672e09a0cb28e1e9ae49e9d96355f522f
treefee8829694480137eacc54987c49d8c845a084ef
parent4961772560d2f19695c73ece943716033ad62ac2
pcm: another weird API abuse

readv() and writev() should _not_ ignore all but the first ->iov_len,
among other things.  Really weird abuse of those syscalls - it
expects a vector element per channel, with identical lengths (it
actually assumes them to be identical - no checking is done).
readv() and writev() are really bad match for that.  Unfortunately,
userland API is userland API and we can't do anything about them.

Converted to ->read_iter/->write_iter.  Please, _please_ don't do
anything of that kind when designing new interfaces.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
sound/core/pcm_native.c