]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: shmobile: R-Mobile: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 10 Oct 2015 12:30:52 +0000 (14:30 +0200)
committerSimon Horman <horms+renesas@verge.net.au>
Mon, 12 Oct 2015 00:15:29 +0000 (09:15 +0900)
commit1fd377b3fc1e071702e27b2f828e3abd8b31c74d
treecea9957d753672e2d224c81a29976a9c47cece16
parente5cf79d9957d958c0c5fd1cbc4eda6c48c563888
ARM: shmobile: R-Mobile: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
arch/arm/mach-shmobile/pm-rmobile.c