]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: usb/endpoint, fix dangling pointer use
authorJiri Slaby <jslaby@suse.cz>
Mon, 21 Jun 2010 15:03:21 +0000 (17:03 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 21 Jun 2010 15:07:58 +0000 (17:07 +0200)
commit272cbc98cfbdd30cff37a35f8ad8f1b737288e88
tree9ac944574d3a98e106a11d362cb69293cacb0d48
parent2a383cb3f1a571b281c2e1ace4c8491f0370e866
ALSA: usb/endpoint, fix dangling pointer use

Stanse found that in snd_usb_parse_audio_endpoints, there is a
dangling pointer dereference. When snd_usb_parse_audio_format fails,
fp is freed, and continue invoked. On the next loop, there is
"fp && fp->altsetting == 1 && fp->channels == 1" test, but fp is set
from the last iteration (but is bogus) and thus ilegally dereferenced.

Set fp to NULL before "continue".

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/endpoint.c