]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: bcmgenet: Fix early link interrupt enabling
authorFlorian Fainelli <f.fainelli@gmail.com>
Sat, 17 Oct 2015 21:22:46 +0000 (14:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Oct 2015 06:07:12 +0000 (23:07 -0700)
commit37850e37fcfb4dd831bc9e33221e8c49a732956f
tree6ad2868a2f479da816ce19eb8666e0456ad70c5d
parentafc050dd8e3387f71def1d6114ecd589f16874df
net: bcmgenet: Fix early link interrupt enabling

Link interrupts are enabled in init_umac(), which is too early for us to
process them since we do not yet have a valid PHY device pointer. On
BCM7425 chips for instance, we will crash calling phy_mac_interrupt()
because phydev is NULL.

Fix this by moving the link interrupts enabling in
bcmgenet_netif_start(), under a specific function:
bcmgenet_link_intr_enable() and while at it, update the comments
surrounding the code.

Fixes: 6cc8e6d4dcb36 ("net: bcmgenet: Delay PHY initialization to bcmgenet_open()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c