]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86, cpu hotplug: Fix stack frame warning in check_irq_vectors_for_cpu_disable()
authorPrarit Bhargava <prarit@redhat.com>
Tue, 28 Jan 2014 13:22:11 +0000 (08:22 -0500)
committerH. Peter Anvin <hpa@linux.intel.com>
Fri, 31 Jan 2014 00:40:13 +0000 (16:40 -0800)
commit39424e89d64661faa0a2e00c5ad1e6dbeebfa972
treeda69b9f3e949fbe7e1aa72e7de2f639ee63f92cd
parentedc6bc784028f2ef80dff0ff697363ff5a06e3a3
x86, cpu hotplug: Fix stack frame warning in check_irq_vectors_for_cpu_disable()

Further discussion here: http://marc.info/?l=linux-kernel&m=139073901101034&w=2

kbuild, 0day kernel build service, outputs the warning:

arch/x86/kernel/irq.c:333:1: warning: the frame size of 2056 bytes
is larger than 2048 bytes [-Wframe-larger-than=]

because check_irq_vectors_for_cpu_disable() allocates two cpumasks on the
stack.   Fix this by moving the two cpumasks to a global file context.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: David Rientjes <rientjes@google.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Link: http://lkml.kernel.org/r/1390915331-27375-1-git-send-email-prarit@redhat.com
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Yang Zhang <yang.z.zhang@Intel.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Janet Morgan <janet.morgan@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Ruiv Wang <ruiv.wang@gmail.com>
Cc: Gong Chen <gong.chen@linux.intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
arch/x86/kernel/irq.c