]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
btrfs: don't accept bare namespace as a valid xattr
authorDavid Sterba <dsterba@suse.cz>
Wed, 25 Mar 2015 18:26:41 +0000 (19:26 +0100)
committerChris Mason <clm@fb.com>
Fri, 27 Mar 2015 01:10:24 +0000 (18:10 -0700)
commit3c3b04d10ff1811a27f86684ccd2f5ba6983211d
tree3ad3d87edc735b1f2445fe92e9d5610ea367af32
parentdcc82f4783ad91d4ab654f89f37ae9291cdc846a
btrfs: don't accept bare namespace as a valid xattr

Due to insufficient check in btrfs_is_valid_xattr, this unexpectedly
works:

 $ touch file
 $ setfattr -n user. -v 1 file
 $ getfattr -d file
user.="1"

ie. the missing attribute name after the namespace.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=94291
Reported-by: William Douglas <william.douglas@intel.com>
CC: <stable@vger.kernel.org> # 2.6.29+
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/xattr.c