]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net/l2tp: don't fall back on UDP [get|set]sockopt
authorSasha Levin <sasha.levin@oracle.com>
Tue, 15 Jul 2014 00:02:31 +0000 (17:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 15 Jul 2014 00:02:31 +0000 (17:02 -0700)
commit3cf521f7dc87c031617fd47e4b7aa2593c2f3daf
tree37448d4d3ec9923ee495c2739be77c715280ce54
parent1795cd9b3a91d4b5473c97f491d63892442212ab
net/l2tp: don't fall back on UDP [get|set]sockopt

The l2tp [get|set]sockopt() code has fallen back to the UDP functions
for socket option levels != SOL_PPPOL2TP since day one, but that has
never actually worked, since the l2tp socket isn't an inet socket.

As David Miller points out:

  "If we wanted this to work, it'd have to look up the tunnel and then
   use tunnel->sk, but I wonder how useful that would be"

Since this can never have worked so nobody could possibly have depended
on that functionality, just remove the broken code and return -EINVAL.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: James Chapman <jchapman@katalix.com>
Acked-by: David Miller <davem@davemloft.net>
Cc: Phil Turnbull <phil.turnbull@oracle.com>
Cc: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/l2tp/l2tp_ppp.c