]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mac80111: aes_ccm: cleanup ieee80211_aes_key_setup_encrypt()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 23 Mar 2015 14:08:14 +0000 (17:08 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 30 Mar 2015 08:40:03 +0000 (10:40 +0200)
commit45fd63293a214c48d6d3856bb39cf207a805dfda
tree95ac3231e1712190dfc607114546093827046f65
parent82ca6ef686f0fcefe2c1ad4ab74d5caf41be03a9
mac80111: aes_ccm: cleanup ieee80211_aes_key_setup_encrypt()

This code is written using an anti-pattern called "success handling"
which makes it hard to read, especially if you are used to normal kernel
style.  It should instead be written as a list of directives in a row
with branches for error handling.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/aes_ccm.c