]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: slicoss: restore IRQs correctly after slic_cmdq_reset()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 19 May 2015 12:25:24 +0000 (15:25 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 May 2015 02:47:56 +0000 (11:47 +0900)
commit46d74c38eba22bee848c205e8a98fc4b6b53a081
treecdaae35f30a26259a010b8f5b9aad75c21d78791
parent24768169c7929e706150ab34731394e42b5215f3
staging: slicoss: restore IRQs correctly after slic_cmdq_reset()

We can't save two different values in "flags" so it means that IRQs are
not enabled properly at the end of this function.  This isn't a problem
in the current code because it's always called with IRQs disabled so we
don't want to enable them at the end.

This bug is old but it's thanks to David Matlack's recent cleanups that
Smatch can detect it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Matlack <dmatlack@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/slicoss/slicoss.c