]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: dgnc: some off by one bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Mar 2015 17:24:31 +0000 (20:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Mar 2015 14:31:24 +0000 (15:31 +0100)
commit4bef52f377b6410a89fc580a8948033f613854f8
tree037515e1fa5cfe94d88646696a58317e1d136ac2
parentedc16d8d481e4c73f9d70d648463d4b25d2c662b
staging: dgnc: some off by one bugs

"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array.  "->nasync" and "->maxports" are the same value.
They are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.

I cleaned up the conditions in dgnc_mgmt_ioctl() a bit.  There was a
work around for the off by one bug in the case where there were no
boards which is no longer needed.  "channel" is unsigned so it can't be
negative.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_cls.c
drivers/staging/dgnc/dgnc_mgmt.c
drivers/staging/dgnc/dgnc_neo.c
drivers/staging/dgnc/dgnc_tty.c