]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pinctrl: at91-pio4: fix pull-up/down logic
authorLudovic Desroches <ludovic.desroches@atmel.com>
Tue, 19 Apr 2016 14:03:45 +0000 (16:03 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 29 Apr 2016 09:16:19 +0000 (11:16 +0200)
commit5305a7b7e860bb40ab226bc7d58019416073948a
tree5e101eb20cb494ff39a2de5e5c12897418ef9d73
parent02da2d72174c61988eb4456b53f405e3ebdebce4
pinctrl: at91-pio4: fix pull-up/down logic

The default configuration of a pin is often with a value in the
pull-up/down field at chip reset. So, even if the internal logic of the
controller prevents writing a configuration with pull-up and pull-down at
the same time, we must ensure explicitly this condition before writing the
register.

This was leading to a pull-down condition not taken into account for
instance.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
Cc: stable@vger.kernel.org #v4.4 and later
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91-pio4.c