]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[SCSI] use the scsi data buffer length to extract transfer size
authorMartin K. Petersen <martin.petersen@oracle.com>
Tue, 24 Jun 2014 14:59:35 +0000 (16:59 +0200)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 3 Jul 2014 17:50:31 +0000 (10:50 -0700)
commit5616b0a46ed82eb9a093f752fc4d7bd3cc688583
tree6de33db88c3848749434ea4e8ad09d111378745e
parenta33c070bced8b283e22e8dbae35177a033b810bf
[SCSI] use the scsi data buffer length to extract transfer size

Commit 8846bab180fa introduced a helper that can be used to query the
wire transfer size for a SCSI command taking protection information into
account.

However, some commands do not have a 1:1 mapping between the block range
they work on and the payload size (discard, write same). After the
scatterlist has been set up these requests use __data_len to store the
number of bytes to report completion on. This means that callers of
scsi_transfer_length() would get the wrong byte count for these types of
requests.

To overcome this we make scsi_transfer_length() use the scatterlist
length in the scsi_data_buffer as basis for the wire transfer
calculation instead of __data_len.

Reported-by: Christoph Hellwig <hch@infradead.org>
Debugged-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Fixes: d77e65350f2d82dfa0557707d505711f5a43c8fd
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
include/scsi/scsi_cmnd.h