]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mmc: pwrseq: Fix error code propagation in mmc_pwrseq_simple_alloc()
authorJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Mon, 13 Apr 2015 14:07:41 +0000 (16:07 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 17 Apr 2015 08:17:19 +0000 (10:17 +0200)
commit636efbc66452659840a9a4df1daf80074ee439f6
tree40cb81847a1a578a3b47319008854a4f91a9ffc4
parent4fc8adcfec3da639da76e8314c9ccefe5bf9a045
mmc: pwrseq: Fix error code propagation in mmc_pwrseq_simple_alloc()

If the struct mmc_pwrseq_match .alloc function used to allocate a
struct mmc_pwrseq fails, the error is propagated to mmc_of_parse().

But instead of returning the error code in pwrseq, host->pwrseq is
returned which will always be 0. So mmc_of_parse() succeeds even if
the pwrseq .alloc function failed and host->pwrseq is NULL.

This makes the SDIO device to not be powered if the power sequencing
.alloc functions wants to be deferred due a missing resource because
the mmc controller driver probe did wrongly succeed.

Fixes: 0f12a0ce4ce4a ("mmc: pwrseq: simplify alloc/free hooks")
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/pwrseq.c