]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
md/raid5: don't record new size if resize_stripes fails.
authorNeilBrown <neilb@suse.de>
Fri, 8 May 2015 08:19:34 +0000 (18:19 +1000)
committerNeilBrown <neilb@suse.de>
Fri, 8 May 2015 08:47:35 +0000 (18:47 +1000)
commit6e9eac2dcee5e19f125967dd2be3e36558c42fff
treed98944269434f5921d00815de13f693b9c4114a5
parent10d82c5f0d167ef75a2d8d7d4eed9ee43d3369c9
md/raid5: don't record new size if resize_stripes fails.

If any memory allocation in resize_stripes fails we will return
-ENOMEM, but in some cases we update conf->pool_size anyway.

This means that if we try again, the allocations will be assumed
to be larger than they are, and badness results.

So only update pool_size if there is no error.

This bug was introduced in 2.6.17 and the patch is suitable for
-stable.

Fixes: ad01c9e3752f ("[PATCH] md: Allow stripes to be expanded in preparation for expanding an array")
Cc: stable@vger.kernel.org (v2.6.17+)
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c