]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Revert "block, dm: don't copy bios for request clones"
authorMike Snitzer <snitzer@redhat.com>
Fri, 26 Jun 2015 14:01:13 +0000 (10:01 -0400)
committerMike Snitzer <snitzer@redhat.com>
Fri, 26 Jun 2015 14:11:58 +0000 (10:11 -0400)
commit78d8e58a086b214dddf1fd463e20a7e1d82d7866
tree2868b9a09eb82b8ecf37ec96fc494838dfdee63a
parent4e6e36c3714364b65f2bfea8c73691c663891726
Revert "block, dm: don't copy bios for request clones"

This reverts commit 5f1b670d0bef508a5554d92525f5f6d00d640b38.

Justification for revert as reported in this dm-devel post:
https://www.redhat.com/archives/dm-devel/2015-June/msg00160.html

this change should not be pushed to mainline yet.

Firstly, Christoph has a newer version of the patch that fixes silent
data corruption problem:
  https://www.redhat.com/archives/dm-devel/2015-May/msg00229.html

And the new version still depends on LLDDs to always complete requests
to the end when error happens, while block API doesn't enforce such a
requirement. If the assumption is ever broken, the inconsistency between
request and bio (e.g. rq->__sector and rq->bio) will cause silent data
corruption:
  https://www.redhat.com/archives/dm-devel/2015-June/msg00022.html

Reported-by: Junichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
block/blk-core.c
drivers/md/dm-table.c
drivers/md/dm.c
drivers/md/dm.h
include/linux/blk_types.h
include/linux/blkdev.h