]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cgroups: fix cgroup_event_listener error handling
authorGreg Thelen <gthelen@google.com>
Mon, 7 Jan 2013 19:50:17 +0000 (11:50 -0800)
committerTejun Heo <tj@kernel.org>
Tue, 8 Jan 2013 18:00:44 +0000 (10:00 -0800)
commit799105d514384b80cbe3182dbcb4ed30aa07e1f5
treea268f0a96609fb09408fb77fd5474489cbb63c76
parent92e015b1cfc24e3cb072385f25171b8599cc7ef3
cgroups: fix cgroup_event_listener error handling

The error handling in cgroup_event_listener.c did not correctly deal
with either an error opening either <control_file> or
cgroup.event_control.  Due to an uninitialized variable the program
exit code was undefined if either of these opens failed.

This patch simplifies and corrects cgroup_event_listener.c error
handling by:
1. using err*() rather than printf(),exit()
2. depending on process exit to close open files

With this patch failures always return non-zero error.

Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/cgroup/cgroup_event_listener.c