]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL
authorAndrey Utkin <andrey.krieger.utkin@gmail.com>
Sat, 26 Jul 2014 11:58:01 +0000 (14:58 +0300)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Sun, 3 Aug 2014 21:05:22 +0000 (17:05 -0400)
commit7a9e75a185e6b3a3860e6a26fb6e88691fc2c9d9
tree4a28dc67cbc45962acfd58e7ba4f56fa83c6084a
parent9806755c56a9a8b3ff8bc9ce3092dcad4d562989
nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL

There was a check for result being not NULL. But get_acl() may return
NULL, or ERR_PTR, or actual pointer.
The purpose of the function where current change is done is to "list
ACLs only when they are available", so any error condition of get_acl()
mustn't be elevated, and returning 0 there is still valid.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81111
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 74adf83f5d77 (nfs: only show Posix ACLs in listxattr if actually...)
Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/nfs3acl.c