]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/probe-helper: Grab mode_config.mutex in poll_init/enable
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 9 Jul 2015 21:44:26 +0000 (23:44 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 22 Jul 2015 14:25:45 +0000 (16:25 +0200)
commit8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
treec982a3c30b849e7ebea40fe2eed4c6757ad63a0a
parent6295d607ad34ee4e43aab3f20714c2ef7a6adea1
drm/probe-helper: Grab mode_config.mutex in poll_init/enable

So on first looks this seems superflous since drivers should ensure
correct ordering to not make this a problem. Otoh ordering constraints
between hdp, fbdev load and enabling polling are already tricky on
some hardware and it helps to be more robust.

But the real goal is to just shut up a locking WARN_ON I'd like to
add, which means init code gets some additional locks just for
uniformity.

v2: Also grab the lock for the public poll_enable, not just poll_init
which is used for resume, with the same justification.

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_probe_helper.c