]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
locking/futex: Check PF_KTHREAD rather than !p->mm to filter out kthreads
authorOleg Nesterov <oleg@redhat.com>
Mon, 2 Feb 2015 14:05:36 +0000 (15:05 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 18 Feb 2015 15:57:09 +0000 (16:57 +0100)
commita21294644623ee41034db60e93aaebed4db0e57b
tree864432246453f636e36544aa601860dde50cc40a
parentbe1f7bf217ebb1e42190d7d0b332c89ea7871378
locking/futex: Check PF_KTHREAD rather than !p->mm to filter out kthreads

attach_to_pi_owner() checks p->mm to prevent attaching to kthreads and
this looks doubly wrong:

1. It should actually check PF_KTHREAD, kthread can do use_mm().

2. If this task is not kthread and it is actually the lock owner we can
   wrongly return -EPERM instead of -ESRCH or retry-if-EAGAIN.

   And note that this wrong EPERM is the likely case unless the exiting
   task is (auto)reaped quickly, we check ->mm before PF_EXITING.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Darren Hart <darren@dvhart.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Jerome Marchand <jmarchan@redhat.com>
Cc: Larry Woodman <lwoodman@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mateusz Guzik <mguzik@redhat.com>
Link: http://lkml.kernel.org/r/20150202140536.GA26406@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/futex.c