]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
netconsole: remove unnecessary netconsole_target_get/out() from write_msg()
authorTejun Heo <tj@kernel.org>
Thu, 25 Jun 2015 22:01:33 +0000 (15:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 26 Jun 2015 00:00:39 +0000 (17:00 -0700)
commita6d403ac96893cb5c5812c2d75de082795f02e5f
tree4a8e7dfdcc89e8ea4025ad13aeacd7b92bbd6c25
parent6fe29354befe4c46eb308b662155d4d8017358e1
netconsole: remove unnecessary netconsole_target_get/out() from write_msg()

write_msg() grabs target_list_lock and walks target_list invoking
netpool_send_udp() on each target.  Curiously, it protects each iteration
with netconsole_target_get/put() even though it never releases
target_list_lock which protects all the members.

While this doesn't harm anything, it doesn't serve any purpose either.
The items on the list can't go away while target_list_lock is held.
Remove the unnecessary get/put pair.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: David Miller <davem@davemloft.net>
Cc: Kay Sievers <kay@vrfy.org>
Cc: Petr Mladek <pmladek@suse.cz>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/netconsole.c