]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mtd: spi-nor: improve wait-till-ready timeout loop
authorBrian Norris <computersforpeace@gmail.com>
Wed, 5 Nov 2014 10:32:03 +0000 (02:32 -0800)
committerBrian Norris <computersforpeace@gmail.com>
Wed, 26 Nov 2014 06:51:23 +0000 (22:51 -0800)
commita95ce92e4b289228c51114dd19f714388093d52b
tree0664ac89d17322f75a025c2d4d7da67893b73880
parent05a221bb1f49e6eebc9a3858cb45506f403b3ab6
mtd: spi-nor: improve wait-till-ready timeout loop

There are a few small issues with the timeout loop in
spi_nor_wait_till_ready():

 * The first operation should not be a reschedule; we should check the
   status register at least once to see if we're complete!

 * We should check the status register one last time after declaring the
   deadline has passed, to prevent a premature timeout error (this is
   theoretically possible if we sleep for a long time after the previous
   status register check).

 * Add an error message, so it's obvious if we ever hit a timeout.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Huang Shijie <shijie.huang@intel.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
drivers/mtd/spi-nor/spi-nor.c