]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/gem: fix mmap vma size calculations
authorDavid Herrmann <dh.herrmann@gmail.com>
Fri, 26 Jul 2013 10:09:32 +0000 (12:09 +0200)
committerDave Airlie <airlied@gmail.com>
Fri, 26 Jul 2013 10:28:02 +0000 (20:28 +1000)
commitaed2c03c8d96ea471b86761129c213e05ab6fbef
tree35ee952a2eccc3226e443eafcd85ef2724633d8f
parent51335df9f044ccfafb029f4d7fbeb11c4526340a
drm/gem: fix mmap vma size calculations

The VMA manager is page-size based so drm_vma_node_size() returns the size
in pages. However, drm_gem_mmap_obj() requires the size in bytes. Apply
PAGE_SHIFT so we no longer get EINVAL during mmaps due to too small
buffers.

This bug was introduced in commit:
  0de23977cfeb5b357ec884ba15417ae118ff9e9b
  "drm/gem: convert to new unified vma manager"

Fixes i915 gtt mmap failure reported by Sedat Dilek in:
  Re: linux-next: Tree for Jul 25 [ call-trace: drm | drm-intel related? ]

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Dave Airlie <airlied@gmail.com>
drivers/gpu/drm/drm_gem.c