]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
HID: rmi: fix some harmless BIT() mistakes
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 May 2015 08:32:56 +0000 (11:32 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 18 May 2015 09:22:53 +0000 (11:22 +0200)
commitaf43c4086cf24c3eb74a968195351163750c82b6
tree04b01b156f190db2f87cb3656c1e1edde633818f
parentd0091f5749eadfce87ce0436994584637a353e2c
HID: rmi: fix some harmless BIT() mistakes

These defines are used like this:

if (!(test_bit(RMI_STARTED, &hdata->flags)))

So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4.  It's harmless because it's done
consistently but static checkers will complain.

Fixes: 9fb6bf02e3ad ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-rmi.c