]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mmc: tmio: prevent endless loop in tmio_mmc_set_clock()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thu, 18 Sep 2014 19:33:49 +0000 (23:33 +0400)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 19 Sep 2014 18:43:09 +0000 (20:43 +0200)
commitbb98d9d1d2e791f368295c9c09c9a03fe3ac0e62
treecba9ae3ea8c136a404e2dce04b31f9a5f09bcc41
parentb9bd7ff8069a7125da897de657da421c497d4f15
mmc: tmio: prevent endless loop in tmio_mmc_set_clock()

I spent a couple of days with the driver just hanging due to me forgetting to
specify the external crystal frequency,  so that clk_get_rate() returned 0 and
thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
acceptable behavior, so I suggest that the minimum frequency is checked for 0
in tmio_mmc_host_probe().

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Ian Molton <ian.molton@codethink.co.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_pio.c