]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
block: drop @tsk from attempt_plug_merge() and explain sync rules
authorTejun Heo <tj@kernel.org>
Wed, 19 Oct 2011 12:33:08 +0000 (14:33 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 19 Oct 2011 12:33:08 +0000 (14:33 +0200)
commitbd87b5898a72b1aef6acf3705c61c9f6372adf0c
treea1954f352d16307d0846e42b2246be6b1594fb9b
parentda8303c63b8de73619884382d6e573d44aae0810
block: drop @tsk from attempt_plug_merge() and explain sync rules

attempt_plug_merge() accesses elevator without holding queue_lock and
may call into ->elevator_bio_merge_fn().  The elvator is guaranteed to
be valid because it's accessed iff the plugged list has requests and
elevator is never exited with live requests, so as long as the
elevator method can deal with unlocked access, this is safe.

Explain the sync rules around attempt_plug_merge() and drop the
unnecessary @tsk parameter.

This patch doesn't introduce any functional change.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c
include/linux/elevator.h