]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
i2c: davinci: Fix smbus Oops with AIC33 usage
authorDirk Behme <dirk.behme@googlemail.com>
Fri, 28 Mar 2008 05:16:12 +0000 (06:16 +0100)
committerKevin Hilman <khilman@deeprootsystems.com>
Thu, 5 Aug 2010 16:38:32 +0000 (09:38 -0700)
commitc6c7c729a22bfeb8e63eafce48dbaeea20e68703
treed1fd3ea71d56b78ed4495d228b2772950a802a3b
parent9fe6206f400646a2322096b56c59891d530e8d51
i2c: davinci: Fix smbus Oops with AIC33 usage

This fixes Oops at kernel startup while "scanning" for TLV320AIC23IDx
addresses.

Additional fix from Sudhakar Rajashekhara: I think 'first byte set'
should come after the write because an I2C transaction is being
carried out before configuring the I2C mode register (which has bits
to configure Master, Start condition etc), which causes undefined
behavior.

Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
Signed-off-by: Alexander Vasiliev <alexvasiljev@gmail.com>
Signed-off-by: Brad Griffis <bgriffis@ti.com>
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
drivers/i2c/busses/i2c-davinci.c