]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
xen/hypercall: fix hypercall fallback code for very old hypervisors
authorJan Beulich <jbeulich@suse.com>
Fri, 19 Oct 2012 19:25:37 +0000 (15:25 -0400)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Sun, 4 Nov 2012 15:40:42 +0000 (10:40 -0500)
commitcf47a83fb06e42ae1b572ed68326068c7feaceae
tree52e694ac8adfc67d8dc82e35e046c14f0ceb10c2
parent95a7d76897c1e7243d4137037c66d15cbf2cce76
xen/hypercall: fix hypercall fallback code for very old hypervisors

While copying the argument structures in HYPERVISOR_event_channel_op()
and HYPERVISOR_physdev_op() into the local variable is sufficiently
safe even if the actual structure is smaller than the container one,
copying back eventual output values the same way isn't: This may
collide with on-stack variables (particularly "rc") which may change
between the first and second memcpy() (i.e. the second memcpy() could
discard that change).

Move the fallback code into out-of-line functions, and handle all of
the operations known by this old a hypervisor individually: Some don't
require copying back anything at all, and for the rest use the
individual argument structures' sizes rather than the container's.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
[v2: Reduce #define/#undef usage in HYPERVISOR_physdev_op_compat().]
[v3: Fix compile errors when modules use said hypercalls]
[v4: Add xen_ prefix to the HYPERCALL_..]
[v5: Alter the name and only EXPORT_SYMBOL_GPL one of them]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
arch/x86/include/asm/xen/hypercall.h
drivers/xen/Makefile
drivers/xen/fallback.c [new file with mode: 0644]