]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: keyspan: fix potential null pointer dereference
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Fri, 16 May 2014 15:39:13 +0000 (17:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 May 2014 22:14:13 +0000 (15:14 -0700)
commitd5afce82e131eb5a171afeba0bc5fefbe2417ad9
tree0ee29f9b6e9df63e64ed94a0951b83b552c3bbeb
parentdf3ce23a56654bbf08e0c36ab1690cd8316a53c4
USB: keyspan: fix potential null pointer dereference

Move control-urb dereference to after NULL-check. There is otherwise a
risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called
cppcheck.

[Johan: modify commit message somewhat ]
[gkh: remove stable tag as it's not a real problem that anyone has ever hit]

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/keyspan.c