]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Staging: speakup: Move pasting into a work item
authorBen Hutchings <ben@decadent.org.uk>
Sun, 18 May 2014 23:56:22 +0000 (00:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2014 17:25:10 +0000 (02:25 +0900)
commitd7500135802ca55b3f4e01a16544e8b34082f8c3
tree67baa0387aee5792f9d62e485e1add9dec14675d
parentffed54dced86723f352323f15789d9ad6bee25e1
Staging: speakup: Move pasting into a work item

Input is handled in softirq context, but when pasting we may
need to sleep.  speakup_paste_selection() currently tries to
bodge this by busy-waiting if in_atomic(), but that doesn't
help because the ldisc may also sleep.

For bonus breakage, speakup_paste_selection() changes the
state of current, even though it's not running in process
context.

Move it into a work item and make sure to cancel it on exit.

References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers <elbrus@debian.org>
Reported-and-tested-by: Jarek Czekalski <jarekczek@poczta.onet.pl>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/main.c
drivers/staging/speakup/selection.c
drivers/staging/speakup/speakup.h