]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
documentation: memory-barriers: Fix smp_mb__before_spinlock() semantics
authorWill Deacon <will.deacon@arm.com>
Tue, 31 Mar 2015 08:39:41 +0000 (09:39 +0100)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 27 May 2015 19:57:27 +0000 (12:57 -0700)
commitd956028e99b30726b0bce0ca684b40b1ad67b514
tree9ac343191ce631a313cf1ac810b61d15b73bea8e
parent7d0ae8086b828311250c6afdf800b568ac9bd693
documentation: memory-barriers: Fix smp_mb__before_spinlock() semantics

Our current documentation claims that, when followed by an ACQUIRE,
smp_mb__before_spinlock() orders prior loads against subsequent loads
and stores, which isn't the intent.  This commit therefore fixes the
documentation to state that this sequence orders only prior stores
against subsequent loads and stores.

In addition, the original intent of smp_mb__before_spinlock() was to only
order prior loads against subsequent stores, however, people have started
using it as if it ordered prior loads against subsequent loads and stores.
This commit therefore also updates smp_mb__before_spinlock()'s header
comment to reflect this new reality.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Documentation/memory-barriers.txt
include/linux/spinlock.h