]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm: Reject DRI1 hw lock ioctl functions for kms drivers
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Jun 2015 09:34:21 +0000 (11:34 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 2 Jul 2015 15:00:48 +0000 (17:00 +0200)
commitda168d81b44898404d281d5dbe70154ab5f117c1
tree0c64a81f5cabf1074613020b4edc47fdac959f98
parentba6976c129a571464fccbbcf866f4f93d91113c0
drm: Reject DRI1 hw lock ioctl functions for kms drivers

I've done some extensive history digging across libdrm, mesa and
xf86-video-{intel,nouveau,ati}. The only potential user of this with
kms drivers I could find was ttmtest, which once used drmGetLock
still. But that mistake was quickly fixed up. Even the intel xvmc
library (which otherwise was really good with using dri1 stuff in kms
mode) managed to never take the hw lock for dri2 (and hence kms).

Hence it should be save to unconditionally disallow this.

Cc: Peter Antoine <peter.antoine@intel.com>
Reviewed-by: Peter Antoine <peter.antoine@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_lock.c