]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ata: ahci_mvebu: Fix wrongly set base address for the MBus window setting
authorNadav Haklai <nadavh@marvell.com>
Tue, 26 May 2015 16:47:23 +0000 (18:47 +0200)
committerTejun Heo <tj@kernel.org>
Tue, 26 May 2015 18:46:15 +0000 (14:46 -0400)
commite96998fc200867f005dd14c7d1dd35e1107d4914
tree5785262bde741764edfea785df605e1657b02a0f
parentdbfe8ef5599a5370abc441fcdbb382b656563eb4
ata: ahci_mvebu: Fix wrongly set base address for the MBus window setting

According to the Armada 38x datasheet, the window base address
registers value is set in bits [31:4] of the register and corresponds
to the transaction address bits [47:20].

Therefore, the 32bit base address value should be shifted right by
20bits and left by 4bits, resulting in 16 bit shift right.

The bug as not been noticed yet because if the memory available on
the platform is less than 2GB, then the base address is zero.

[gregory.clement@free-electrons.com: add extra-explanation]

Fixes: a3464ed2f14 (ata: ahci_mvebu: new driver for Marvell Armada 380
AHCI interfaces)
Signed-off-by: Nadav Haklai <nadavh@marvell.com>
Reviewed-by: Omri Itach <omrii@marvell.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/ahci_mvebu.c