]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[media] si2165: Fix possible leak in si2165_upload_firmware()
authorChristian Engelmayer <cengelma@gmx.at>
Wed, 11 Feb 2015 20:58:23 +0000 (17:58 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 8 Apr 2015 11:12:00 +0000 (08:12 -0300)
commitec73b9fdc7c4fe3da8937a8e7b6a03a1e002d6ac
tree6a2661e8d3c9860f70f21bafb36848051c2131c7
parent51b5b3d6c96ee244c51ec57265fc3c5ae5897610
[media] si2165: Fix possible leak in si2165_upload_firmware()

In case of an error function si2165_upload_firmware() releases the already
requested firmware in the exit path. However, there is one deviation where
the function directly returns. Use the correct cleanup so that the firmware
memory gets freed correctly. Detected by Coverity CID 1269120.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Reviewed-by: Luis de Bethencourt <luis.bg@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/si2165.c