]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: 7931/1: Correct virt_addr_valid
authorLaura Abbott <lauraa@codeaurora.org>
Sat, 21 Dec 2013 00:03:06 +0000 (01:03 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 29 Dec 2013 12:46:08 +0000 (12:46 +0000)
commitefea3403d4b7c6d1dd5d5ac3234c161e8b314d66
tree588229afaf191338ca5b14672d4fd4bc40ef36b2
parent2a7cfcbc0553365d75716f69ee7b704cac7c9248
ARM: 7931/1: Correct virt_addr_valid

The definition of virt_addr_valid is that virt_addr_valid should
return true if and only if virt_to_page returns a valid pointer.
The current definition of virt_addr_valid only checks against the
virtual address range. There's no guarantee that just because a
virtual address falls bewteen PAGE_OFFSET and high_memory the
associated physical memory has a valid backing struct page. Follow
the example of other architectures and convert to pfn_valid to
verify that the virtual address is actually valid. The check for
an address between PAGE_OFFSET and high_memory is still necessary
as vmalloc/highmem addresses are not valid with virt_to_page.

Cc: Will Deacon <will.deacon@arm.com>
Cc: Nicolas Pitre <nico@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/include/asm/memory.h