]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mwifiex: don't leak 'chan_stats' on reset
authorBrian Norris <briannorris@chromium.org>
Fri, 14 Apr 2017 21:51:20 +0000 (14:51 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 20 Apr 2017 07:21:53 +0000 (10:21 +0300)
commitfb9e67bee3ab7111513130c516ffe378d885c0d0
treedbf33a4ac3d8053672606c54c5c2f2496f3db505
parent35e67d3d58b955fe35d78ce439b4fa996a9eadcd
mwifiex: don't leak 'chan_stats' on reset

'chan_stats' is (re)allocated in _mwifiex_fw_dpc() ->
mwifiex_init_channel_scan_gap(), which is called whenever the device is
initialized -- at probe or at reset.

But we only free it in we completely unregister the adapter, meaning we
leak a copy of it during every reset.

Let's free it in the shutdown / removal paths instead (and in the
error-handling path), to avoid the leak.

Ideally, we can eventually unify much of mwifiex_shutdown_sw() and
mwifiex_remove_card() (way too much copy-and-paste) to reduce the burden
on bugfixes like this. But that's work for tomorrow.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/main.c