]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
pwm: renesas-tpu: fix return value check in tpu_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 25 Jun 2013 02:09:57 +0000 (10:09 +0800)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 25 Jun 2013 10:20:06 +0000 (12:20 +0200)
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-renesas-tpu.c

index 96e0cc488a4ebb334e6129a7d92afe0196eaba60..03c1aa3c48a299b9ae60ebb532dcfc34d2b38ee9 100644 (file)
@@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev)
        }
 
        tpu->base = devm_ioremap_resource(&pdev->dev, res);
-       if (tpu->base == NULL) {
-               dev_err(&pdev->dev, "failed to remap I/O memory\n");
-               return -ENXIO;
-       }
+       if (IS_ERR(tpu->base))
+               return PTR_ERR(tpu->base);
 
        tpu->clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(tpu->clk)) {