]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
isdn_ppp: Add checks for allocation failure in isdn_ppp_open()
authorBen Hutchings <ben@decadent.org.uk>
Sun, 1 Nov 2015 16:21:24 +0000 (16:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Nov 2015 21:25:00 +0000 (16:25 -0500)
Compile-tested only.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/i4l/isdn_ppp.c

index c4198fa490bfac50dd3c05fa324502d4e6f228c8..86f9abebcb72af8b6f88440a500b7737933e77a0 100644 (file)
@@ -301,6 +301,8 @@ isdn_ppp_open(int min, struct file *file)
        is->compflags = 0;
 
        is->reset = isdn_ppp_ccp_reset_alloc(is);
+       if (!is->reset)
+               return -ENOMEM;
 
        is->lp = NULL;
        is->mp_seqno = 0;       /* MP sequence number */
@@ -320,6 +322,10 @@ isdn_ppp_open(int min, struct file *file)
         * VJ header compression init
         */
        is->slcomp = slhc_init(16, 16); /* not necessary for 2. link in bundle */
+       if (!is->slcomp) {
+               isdn_ppp_ccp_reset_free(is);
+               return -ENOMEM;
+       }
 #endif
 #ifdef CONFIG_IPPP_FILTER
        is->pass_filter = NULL;