]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ALSA: hda - Disable widget power-saving for ALC292 & co
authorTakashi Iwai <tiwai@suse.de>
Wed, 20 May 2015 04:56:23 +0000 (06:56 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 20 May 2015 04:56:23 +0000 (06:56 +0200)
We've got reports that ALC3226 (a Dell variant of ALC292) gives click
noises at transition from D3 to D0 when the widget power-saving is
enabled.  Further debugging session showed that avoiding it isn't
trivial, unfortunately, since paths are basically activated
dynamically while the pins have been already enabled.

This patch disables the widget power-saving for such codecs.

Reported-by: Jonathan McDowell <noodles@earth.li>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index 2e246fe495f622ab99bf10aef796efdc371a5772..31f8f13be907a298fe7b785c33acb56b36fa4d5c 100644 (file)
@@ -5623,7 +5623,8 @@ static int patch_alc269(struct hda_codec *codec)
 
        spec = codec->spec;
        spec->gen.shared_mic_vref_pin = 0x18;
-       codec->power_save_node = 1;
+       if (codec->core.vendor_id != 0x10ec0292)
+               codec->power_save_node = 1;
 
        snd_hda_pick_fixup(codec, alc269_fixup_models,
                       alc269_fixup_tbl, alc269_fixups);