]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ia64/PCI: Use common struct resource_entry to replace struct iospace_resource
authorJiang Liu <jiang.liu@linux.intel.com>
Wed, 14 Oct 2015 06:29:38 +0000 (14:29 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 16 Oct 2015 20:18:51 +0000 (22:18 +0200)
Use common struct resource_entry to replace private
struct iospace_resource.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
arch/ia64/include/asm/pci.h
arch/ia64/pci/pci.c

index 36d2c1e3928bc744eb2d66eeb18aa7291969eab5..07039d168f37bfd14048e9e4a73d50bc4d20f35d 100644 (file)
@@ -64,11 +64,6 @@ extern int pci_mmap_legacy_page_range(struct pci_bus *bus,
 #define pci_legacy_read platform_pci_legacy_read
 #define pci_legacy_write platform_pci_legacy_write
 
-struct iospace_resource {
-       struct list_head list;
-       struct resource res;
-};
-
 struct pci_controller {
        struct acpi_device *companion;
        void *iommu;
index d20db9e480145613fe34649871c5d5f5a8ae3b28..b1846b891ea556e143d9fae15f8a527cc8120c9c 100644 (file)
@@ -154,14 +154,14 @@ new_space (u64 phys_base, int sparse)
 static int add_io_space(struct device *dev, struct pci_root_info *info,
                        struct resource_entry *entry)
 {
-       struct iospace_resource *iospace;
+       struct resource_entry *iospace;
        struct resource *resource, *res = entry->res;
        char *name;
        unsigned long base, min, max, base_port;
        unsigned int sparse = 0, space_nr, len;
 
        len = strlen(info->name) + 32;
-       iospace = kzalloc(sizeof(*iospace) + len, GFP_KERNEL);
+       iospace = resource_list_create_entry(NULL, len);
        if (!iospace) {
                dev_err(dev, "PCI: No memory for %s I/O port space\n",
                        info->name);
@@ -190,7 +190,7 @@ static int add_io_space(struct device *dev, struct pci_root_info *info,
        if (space_nr == 0)
                sparse = 1;
 
-       resource = &iospace->res;
+       resource = iospace->res;
        resource->name  = name;
        resource->flags = IORESOURCE_MEM;
        resource->start = base + (sparse ? IO_SPACE_SPARSE_ENCODING(min) : min);
@@ -205,12 +205,12 @@ static int add_io_space(struct device *dev, struct pci_root_info *info,
        entry->offset = base_port;
        res->start = min + base_port;
        res->end = max + base_port;
-       list_add_tail(&iospace->list, &info->io_resources);
+       resource_list_add_tail(iospace, &info->io_resources);
 
        return 0;
 
 free_resource:
-       kfree(iospace);
+       resource_list_free_entry(iospace);
        return -ENOSPC;
 }
 
@@ -369,12 +369,11 @@ static void add_resources(struct pci_root_info *info, struct device *dev)
 static void __release_pci_root_info(struct pci_root_info *info)
 {
        struct resource *res;
-       struct iospace_resource *iospace, *tmp;
        struct resource_entry *entry, *tentry;
 
-       list_for_each_entry_safe(iospace, tmp, &info->io_resources, list) {
-               release_resource(&iospace->res);
-               kfree(iospace);
+       resource_list_for_each_entry_safe(entry, tentry, &info->io_resources) {
+               release_resource(entry->res);
+               resource_list_destroy_entry(entry);
        }
 
        resource_list_for_each_entry_safe(entry, tentry, &info->resources) {