]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
lguest: fix pending interrupt test.
authorRusty Russell <rusty@rustcorp.com.au>
Fri, 20 Mar 2015 03:48:12 +0000 (14:18 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Fri, 20 Mar 2015 04:37:08 +0000 (15:07 +1030)
Denys says:
  TEST with zero will always set ZF. Thus, "jnz send_interrupts" never jumps.

We get interrupts regularly enough that this didn't cause immediate problems.

Reported-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
arch/x86/lguest/head_32.S

index 6ddfe4fc23c3eefbfe4bb10f726ce27bc51a2fba..05b0a85507ce85bf3f3d43381172278ba212a3a8 100644 (file)
@@ -84,7 +84,7 @@ ENTRY(lg_irq_enable)
         * set lguest_data.irq_pending to X86_EFLAGS_IF.  If it's not zero, we
         * jump to send_interrupts, otherwise we're done.
         */
-       testl $0, lguest_data+LGUEST_DATA_irq_pending
+       cmpl $0, lguest_data+LGUEST_DATA_irq_pending
        jnz send_interrupts
        /*
         * One cool thing about x86 is that you can do many things without using