]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
tty: ioc3_serial.c: move assignment out of if () block
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2015 09:22:11 +0000 (11:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2015 17:04:17 +0000 (19:04 +0200)
We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Pat Gefre <pfg@sgi.com>
CC: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ioc3_serial.c

index abd7ea26ed9af2e3589d0692f1c205de913de889..27b5fefac17167ae4565e7dc43f1dc942c0ec275 100644 (file)
@@ -2137,7 +2137,8 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd)
 
        /* register port with the serial core */
 
-       if ((ret = ioc3_serial_core_attach(is, idd)))
+       ret = ioc3_serial_core_attach(is, idd);
+       if (ret)
                goto out4;
 
        Num_of_ioc3_cards++;