]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: gadget: f_ncm: fix missing unlock on error in ncm_alloc()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 18 Jun 2013 03:43:29 +0000 (11:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2013 17:50:08 +0000 (10:50 -0700)
Add the missing unlock before return from function ncm_alloc()
in the error handling case.

Introduced by commit e730660378be92b83288b59b824ccdace5cd2652.
(usb: gadget: f_ncm: add configfs support)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_ncm.c

index 47a5724211cd3526a0f87a931a6ec3e45b845e24..952177f7eb9b40e8045bfa85730239ab22efd97c 100644 (file)
@@ -1403,6 +1403,7 @@ struct usb_function *ncm_alloc(struct usb_function_instance *fi)
                                      sizeof(ncm->ethaddr));
        if (status < 12) { /* strlen("01234567890a") */
                kfree(ncm);
+               mutex_unlock(&opts->lock);
                return ERR_PTR(-EINVAL);
        }
        ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr;