]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
crypto: user - fix empty string test in report API
authorMathias Krause <minipli@googlemail.com>
Tue, 5 Feb 2013 17:19:14 +0000 (18:19 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 19 Feb 2013 12:27:04 +0000 (20:27 +0800)
The current test for empty strings fails because it is testing the
address of a field, not a pointer. So the test will always be true.
Test the first character in the string to not be null instead.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/crypto_user.c

index f6d9baf77f0a41b76b0fc39aebf26365a1284bca..423a267022f4acc6e7d6db6736341b80153595e9 100644 (file)
@@ -196,7 +196,7 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
        struct crypto_dump_info info;
        int err;
 
-       if (!p->cru_driver_name)
+       if (!p->cru_driver_name[0])
                return -EINVAL;
 
        alg = crypto_alg_match(p, 1);